Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assertions with RuntimeError exceptions #14186

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Replace assertions with RuntimeError exceptions #14186

merged 1 commit into from
Oct 28, 2021

Conversation

ddrm86
Copy link
Contributor

@ddrm86 ddrm86 commented Oct 28, 2021

Replaces the assertions in integrations.py with RuntimeError exceptions.

Contributes towards fixing issue #12789

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

LysandreJik
LysandreJik approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @ddrm86!

@LysandreJik LysandreJik merged commit 4469010 into huggingface:master Oct 28, 2021
@ddrm86 ddrm86 deleted the fix-integrations-assertions branch October 29, 2021 05:12
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
@ddrm86
Replace assertions with RuntimeError exceptions (huggingface#14186)
d949f69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ddrm86 @LysandreJik