Fix of issue #13327: Wrong weight initialization for TF t5 model #14241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! The only change I'd suggest is that we don't usually sign names on comments - there are a lot of contributors to this repo and it could get out of hand. |
Rocketknight1
approved these changes
Nov 3, 2021
|
Looks good! Let me know when you're happy and I'll merge it. |
|
You can merge it. I only saw your comment and didnt see you already pushed a fix that removed all my comments in code, this is why i pushed a fix. Any solution is ok with me... |
|
We're leaving the comments in, just with the author attributions removed. Thanks for your contribution, I'm merging now! |
LysandreJik
pushed a commit
that referenced
this pull request
Nov 16, 2021
) * Fix of issue #13327: Wrong weight initialization for TF t5 model * run black formatter * fix typo * remove my name tag from comments Co-authored-by: Shirron <dan.shirron@intel.com>
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
… model (huggingface#14241) * Fix of issue huggingface#13327: Wrong weight initialization for TF t5 model * run black formatter * fix typo * remove my name tag from comments Co-authored-by: Shirron <dan.shirron@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # 13327
Who can review?
@patrickvonplaten