Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more instructions to the release guide #14263

Merged
merged 4 commits into from
Nov 3, 2021
Merged

Add more instructions to the release guide #14263

merged 4 commits into from
Nov 3, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Nov 3, 2021

What does this PR do?

Add a few updates to the release guides with sample commands to run in the install test.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating it!

setup.py Outdated Show resolved Hide resolved
setup.py Outdated
Comment on lines 56 to 62
10. Run `make post-release` (or `make post-patch` for a patch release).
11. Run `make post-release` (or `make post-patch` for a patch release).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For post-patch it actually needs to be checked out on master, would be nice to mention it

@sgugger sgugger merged commit 1a674ce into master Nov 3, 2021
@sgugger sgugger deleted the release_guide branch November 3, 2021 21:45
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
* Add more instructions to the release guide

* Apply suggestions from code review

Co-authored-by: Lysandre Debut <lysandre@huggingface.co>

* Address review comment

Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants