[Marian Conversion] Fix eos_token_id conversion in conversion script #14320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
commented
Nov 8, 2021
| @@ -492,7 +492,8 @@ def __init__(self, source_dir): | |||
| d_model=cfg["dim-emb"], | |||
| activation_function=cfg["transformer-aan-activation"], | |||
| pad_token_id=self.pad_token_id, | |||
| eos_token_id=0, | |||
| eos_token_id=eos_token_id, | |||
| forced_eos_token_id=eos_token_id, | |||
There was a problem hiding this comment.
We need this as well since forced_eos_token_id was introduced 6 months ago
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed offline with @jorgtied , the conversion script should not assume that the model's
eos_token_idis always 0 but rather retrieve it from the tokenizer.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.