Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Seq2Seq QA example script to use SQuAD metric. #14335

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Update Seq2Seq QA example script to use SQuAD metric. #14335

merged 3 commits into from
Nov 9, 2021

Conversation

karthikrangasai
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@karthikrangasai karthikrangasai mentioned this pull request Nov 9, 2021
Closed
5 tasks
@sgugger sgugger self-requested a review November 9, 2021 12:48
sgugger
sgugger approved these changes Nov 9, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work on this, and for opening a clean PR!

@sgugger sgugger merged commit 4f24058 into huggingface:master Nov 9, 2021
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
@karthikrangasai
Update Seq2Seq QA example script to use SQuAD metric. (huggingface#14335
bd0bfe1 
)

* Update postporcessing accordingly to use SQuAD metric.

* Update assets accordingly based on SQuAD metrics.

* Fix function naming error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NielsRogge NielsRogge NielsRogge left review comments

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karthikrangasai @sgugger @NielsRogge