Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wav2Vec2] Add New Wav2Vec2 Translation #14392

Merged
merged 14 commits into from
Nov 17, 2021

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Nov 15, 2021

What does this PR do?

This PR extends Wav2Vec2 with an Adapter module that allows to take any pretrained Wav2Vec2 checkpoint and down-project to a more suitable size for the encoder-decoder design.

Since, this code originates from the original Wav2Vec2 Fairseq implementation and is applicable to all existing Wav2Vec2 checkpoints, I think it's ok to put it in the existing modeling_wav2vec2.py even if it adds some ugly flags to the config.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten patrickvonplaten changed the title [Wav2Vec2] Add new wav2vec2 translation [Wav2Vec2] Add New Wav2Vec2 Translation Nov 16, 2021
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look fine to me, I'm just curious about the name "adaptor", did you mean "adapter"?

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@patrickvonplaten patrickvonplaten merged commit 700a748 into huggingface:master Nov 17, 2021
@patrickvonplaten patrickvonplaten deleted the s2t-wav2vec2-2 branch November 17, 2021 13:39
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
* add new wav2vec2 translation

* correct

* up

* add tests

* correct end copy

* correct more

* up

* correct unispeech sat

* finish

* finalize

* finish

* up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants