-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wav2Vec2] Add New Wav2Vec2 Translation #14392
Merged
patrickvonplaten
merged 14 commits into
huggingface:master
from
patrickvonplaten:s2t-wav2vec2-2
Nov 17, 2021
Merged
[Wav2Vec2] Add New Wav2Vec2 Translation #14392
patrickvonplaten
merged 14 commits into
huggingface:master
from
patrickvonplaten:s2t-wav2vec2-2
Nov 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/transformers/models/speech_encoder_decoder/modeling_speech_encoder_decoder.py
Show resolved
Hide resolved
patrickvonplaten
changed the title
[Wav2Vec2] Add new wav2vec2 translation
[Wav2Vec2] Add New Wav2Vec2 Translation
Nov 16, 2021
LysandreJik
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes themselves look fine to me, I'm just curious about the name "adaptor", did you mean "adapter"?
src/transformers/models/speech_encoder_decoder/modeling_speech_encoder_decoder.py
Show resolved
Hide resolved
sgugger
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
...sformers/models/speech_encoder_decoder/convert_mbart_wav2vec2_seq2seq_original_to_pytorch.py
Outdated
Show resolved
Hide resolved
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
* add new wav2vec2 translation * correct * up * add tests * correct end copy * correct more * up * correct unispeech sat * finish * finalize * finish * up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR extends Wav2Vec2 with an Adapter module that allows to take any pretrained Wav2Vec2 checkpoint and down-project to a more suitable size for the encoder-decoder design.
Since, this code originates from the original Wav2Vec2 Fairseq implementation and is applicable to all existing Wav2Vec2 checkpoints, I think it's ok to put it in the existing
modeling_wav2vec2.py
even if it adds some ugly flags to the config.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.