Adding support for hidden_states and attentions in unbatching support.
#14420
Conversation
| @require_torch | ||
| def test_unbatch_attentions_hidden_states(self): | ||
| model = DistilBertForSequenceClassification.from_pretrained( | ||
| "Narsil/tiny-distilbert-sequence-classification", output_hidden_states=True, output_attentions=True |
There was a problem hiding this comment.
Can this leverage the one from hf-internal-testing, or is there a reason you favor this one?
There was a problem hiding this comment.
There is not tiny-distilbert in hf-internal-testing, only the random one.
Happy to upload it if you want (as well as all the other Narsil specific tests that probably all belong in hf-internal-testing.
For instance this one was just copied from the text-classification tests.
There was a problem hiding this comment.
Right, but the random has random weights but actually has the weights so it wouldn't be initialized randomly every time you load it in memory.
It shouldn't be an issue here given that you're only checking the length of outputs, right?
There was a problem hiding this comment.
Well I am using these also in other tests, are you ok if I merge this PR, then open another PR to remove Narsil/ models from a bit everywhere (some check actual output values)
What does this PR do?
Fixes #14414
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.