Add a post init method to all models #14431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
approved these changes
Nov 17, 2021
LysandreJik
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
This looks good to me and I don't think it hurts readability, but I don't feel strongly about it. If you'd rather the self.init_weights call stay in each modeling file, that's also fine by me @patrickvonplaten
5 tasks
Merged
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
* Add a post init method to all models * Fix tests * Fix last tests * Fix templates * Add comment * Forgot to save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces the proper fix for #14388 by introducing a new
post_initmethod to each model, which replaces the currentinit_weights()call. The method can execute any code that requires the model to be properly initialized, such as theinit_weights()or the gradient checkpointing BC fix (and more if need to in the future).