[test] add test for --config_overrides #14466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
approved these changes
Nov 20, 2021
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
* add test for --config_overrides * remove unneeded parts of the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14389 suggested that
--config_overridesdoesn't work.The feature works just fine, it's just the multiple logging of the config done by the framework is confusing. I already flagged this issue here: #11104 I have no idea why loading a tokenizer triggers dumping of model config - as its contents are mostly irrelevant to the tokenizer and surely doesn't contribute anything useful to the user, other than avoiding looking at the log completely.
So there will be no confusion I added an additional dump with the updated config (terrible!) and a test so that we don't accidentally break this feature.
I'm not sure how else to improve that other than revisiting the design of when the model config is dumped. IMHO:
Fixes: #14389
@sgugger, @LysandreJik