Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Tuple as possible type hint for EvalPredictions label_ids #14473

Merged
merged 2 commits into from
Nov 21, 2021

Conversation

ameasure
Copy link
Contributor

What does this PR do?

This adds Tuple as a type hint for the label_ids attribute in EvalPredictions. It is a valid type that label_ids can have.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@stas00

@stas00
Copy link
Contributor

stas00 commented Nov 21, 2021

If that's the case, then for consistency the following 2 classes should have the proposed changed as well.

@sgugger, what do you think?

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the type!
I agree with @stas00 remark on the two following classes.

affects EvalLoopOutput and PredicctionOutput
@sgugger sgugger merged commit c9d2cf8 into huggingface:master Nov 21, 2021
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
…gface#14473)

* Update trainer_utils.py

* add Tuple type hints to all label_ids outputs

affects EvalLoopOutput and PredicctionOutput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants