Fix a Bug, trainer_seq2seq.py, in the else branch at Line 172, generation_inputs should be a dict #14546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct before feeding into self.model.generation()
…ct before feeding into self.model.generation()
|
Hey @TranSirius, Thanks a lot for your PR here! It looks good to me - @sgugger can you maybe take a look as well? |
|
Should we maybe write some tests for this use case as well? |
|
Oops didn't see your comment @patrickvonplaten. Adding a test would be nice to have indeed @TranSirius if you want to work on it on a separate PR. |
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
…tion_inputs should be a dict (huggingface#14546) * fix bug, trainer_seq2seq.py, Line 172, generation_inputs must be a dict before feeding into self.model.generation() * fix bug, trainer_seq2seq.py, Line 172, generation_inputs must be a dict before feeding into self.model.generation()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Bug
Fixes # (issue)
In
trainer_seq2seq.py / Seq2SeqTrainer / prediction_step, Line 174 reads:which require the generated_tokens to be a
dict. However, in theelsebranch in Line 171, thegeneration_inputsis created as aTensorobject, which will cause a problem.Fix this by creating
generation_inputsas a dict, and add a key calledinput_ids.