Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flax] token-classification model steps enumerate start from 1 #14547

Merged
merged 2 commits into from
Nov 29, 2021
Merged

[Flax] token-classification model steps enumerate start from 1 #14547

merged 2 commits into from
Nov 29, 2021

Conversation

kamalkraj
Copy link
Contributor

What does this PR do?

Model saving at the last step was skipped due to enumerate starting at 0.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sgugger @patil-suraj

sgugger
sgugger reviewed Nov 28, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think it makes more sense to adjust the computation of cur_step a few lines below instead, what do you think?

@kamalkraj
Copy link
Contributor Author

You mean here

transformers/examples/flax/token-classification/run_flax_ner.py

Line 602 in 2b87fda

cur_step = epoch * step_per_epoch + step

Like this cur_step = (epoch * step_per_epoch) + (step + 1)

@sgugger
Copy link
Collaborator

sgugger commented Nov 29, 2021

Yes, exactly!

patil-suraj
patil-suraj approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing

@patil-suraj patil-suraj merged commit 2bd950c into huggingface:master Nov 29, 2021
@kamalkraj kamalkraj deleted the flax-ner-save-last-step-fix branch November 29, 2021 17:56
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
@kamalkraj
[Flax] token-classification model steps enumerate start from 1 (huggi…
62502b4 
…ngface#14547)

* step start from 1

* Updated cur_step calcualtion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger left review comments

@patil-suraj patil-suraj patil-suraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamalkraj @sgugger @patil-suraj