Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change tf.math.divide with int(/) in distilbert model #14600

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

yis11178
Copy link
Contributor

@yis11178 yis11178 commented Dec 2, 2021

What does this PR do?

This PR changes tf.math.divide with int( / ) for variable dim_per_head. Originally dim_per_head is returned as a float64 tensor and is included in the TF graph. This is not supported by some machines and there is not a solid reason to include it into the TF graph. Hence, this PR removes it from the TF graph and allows for better compatibility with user's device.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Rocketknight1

@Rocketknight1
Copy link
Member

This is a simple change with a clear rationale, and all tests pass, so I'm happy to merge it. Thank you for this PR!

@Rocketknight1 Rocketknight1 merged commit 96cc02b into huggingface:master Dec 2, 2021
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants