Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong checkpoint paths in doc examples #14685

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Dec 8, 2021

What does this PR do?

In some (PT) model files, there are doc examples with the wrong checkpoint paths. For example,

model = BigBirdPegasusForConditionalGeneration.from_pretrained('bigbird-pegasus-large-arxiv')

which should be 'google/bigbird-pegasus-large-arxiv'

This PR fixes this issue.

There is

MegatronBertLMHeadModel.from_pretrained('nvidia/megatron-bert-cased-345m', is_decoder=True)

but there is no model file at all when I searched megatron-bert. I am not sure what to do in this case.

Who can review?

@sgugger @LysandreJik

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing those. For Megatron BERT, a manual download is required, see the doc page for more information.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Dec 8, 2021

Thanks for fixing those. For Megatron BERT, a manual download is required, see the doc page for more information.

OK, so I should update the doc example by using a manual download, I guess.

@sgugger
Copy link
Collaborator

sgugger commented Dec 8, 2021

No need for that (as it requires some bash commands), we just shouldn't test this one.

@sgugger sgugger merged commit 16870d1 into huggingface:master Dec 8, 2021
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
@ydshieh ydshieh deleted the fix_doc_example_002 branch May 5, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants