Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WavLM] Layerdrop is not allowed for first layer #14811

Merged

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Dec 17, 2021

What does this PR do?

Fixes flaky CI. WavLM makes use of relative position encoding that are always computed in the first attention layer and then passed down to subsequent layers. Hence the first layer cannot be skipped when using layerdrop.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten patrickvonplaten merged commit bdbe3df into huggingface:master Dec 17, 2021
@patrickvonplaten patrickvonplaten deleted the fix_layerdrop_wavlm branch December 17, 2021 12:30
@sgugger
Copy link
Collaborator

sgugger commented Dec 17, 2021

Thanks for fixing!

Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
* [WavLM] Layerdrop is not allowed for first layer

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants