Fix Perceiver code example #14879
Merged
Fix Perceiver code example #14879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsRogge
commented
Dec 22, 2021
| @@ -72,7 +72,7 @@ size of 262 byte IDs). | |||
| <img src="https://huggingface.co/datasets/huggingface/documentation-images/resolve/main/perceiver_architecture.jpg" | |||
| alt="drawing" width="600"/> | |||
|
|
|||
| <small> Perceiver IO architecture. Taken from the [original paper](https://arxiv.org/abs/2105.15203) </small> | |||
| <small> Perceiver IO architecture. Taken from the <a href="https://arxiv.org/abs/2105.15203">original paper</a> </small> | |||
There was a problem hiding this comment.
Is this the correct way of adding a hyperlink below a figure of the model?
There was a problem hiding this comment.
Yes. Note that you can try your HTML code with many tools (Google is your friend) or in a notebook with:
from IPython.display import display, HTML
display(HTML(html_code))
sgugger
approved these changes
Dec 22, 2021
| @@ -72,7 +72,7 @@ size of 262 byte IDs). | |||
| <img src="https://huggingface.co/datasets/huggingface/documentation-images/resolve/main/perceiver_architecture.jpg" | |||
| alt="drawing" width="600"/> | |||
|
|
|||
| <small> Perceiver IO architecture. Taken from the [original paper](https://arxiv.org/abs/2105.15203) </small> | |||
| <small> Perceiver IO architecture. Taken from the <a href="https://arxiv.org/abs/2105.15203">original paper</a> </small> | |||
There was a problem hiding this comment.
Yes. Note that you can try your HTML code with many tools (Google is your friend) or in a notebook with:
from IPython.display import display, HTML
display(HTML(html_code))
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the code example of the multimodal Perceiver model.
Fixes #14870