Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Generate] Greedy Search, fix output scores from logits to scores #17442

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented May 26, 2022

What does this PR do?

馃毃馃毃 This PR can lead to silently changing values for users of greedy_search and output_scores=True. Please read the issue below 馃毃 馃毃

Fixes #17424

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten patrickvonplaten changed the title [Generate] Fix output scores greedy search [Generate] Greedy Search, fix output scores from logits to scores May 26, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 26, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, so that the output is consistently scores.

Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

馃毃馃毃 This PR can lead to silently changing values for users of greedy_search and output_scores=True. Please read the issue below 馃毃 馃毃

went through the issue, and it's fine for me since this will actually return the correct scores.

@patrickvonplaten patrickvonplaten merged commit b0e0ac8 into huggingface:main May 31, 2022
@patrickvonplaten patrickvonplaten deleted the fix_greedy_search_output_scores branch May 31, 2022 12:59
Narsil pushed a commit to Narsil/transformers that referenced this pull request Jun 7, 2022
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Jun 16, 2022
@xkianteb
Copy link

@patil-suraj Will there be any support for raw logits instead logits that are processed? (see #17521 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behavior in generate when output_scores=True
5 participants