Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept trust_remote_code and ignore it in PreTrainedModel.from_pretrained #18428

Merged
merged 2 commits into from Aug 2, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Aug 2, 2022

What does this PR do?

Hope my understanding is correct. Let me know if I should apply the same change to ProcessorMixin, PreTrainedTokenizerBase etc.

@ydshieh ydshieh requested a review from sgugger August 2, 2022 16:06
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 2, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

src/transformers/modeling_utils.py Outdated Show resolved Hide resolved
@ydshieh
Copy link
Collaborator Author

ydshieh commented Aug 2, 2022

@sgugger FYI:

I applied the change to TF and Flax PreTrainedModel (which is necessary, at least for TF), as well as PretrainedConfig.
Leave the tokenizer class and feature extractor class for now

@ydshieh ydshieh merged commit c382ed8 into huggingface:main Aug 2, 2022
LysandreJik pushed a commit that referenced this pull request Aug 24, 2022
…trained` (#18428)

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
@ydshieh ydshieh deleted the accept_and_ignore_kwarg branch September 7, 2022 08:10
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
…trained` (huggingface#18428)

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants