Make AutoProcessor a magic loading class for all modalities #18963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
LysandreJik
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Thank you for your PR! Simple and elegant. I can't think of a repository that would have a feature extractor and a tokenizer, but no processor.
Looks good to me! @patrickvonplaten, could you give it a look?
| # At this stage, there doesn't seem to be a `Processor` class available for this model, so let's try a | ||
| # tokenizer. | ||
| try: | ||
| return AutoTokenizer.from_pretrained( |
There was a problem hiding this comment.
I guess the order doesn't matter too much here since if both tokenizer and feature extractor would be present then the model also should have a processor?
There was a problem hiding this comment.
Yes, I don't see when we could have both without a processor.
patrickvonplaten
approved these changes
Sep 13, 2022
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
…ace#18963) * Make AutoProcessor a magic loading class for all modalities * Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR re-enables a feature initially part of #14465 : the fact that
AutoProcessoris a class loading the right processing class for any model (so processor, tokenizer or feature extractor). You can thus do:or