Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokenizer load from one file #19073

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Fix tokenizer load from one file #19073

merged 3 commits into from
Sep 16, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Sep 16, 2022

What does this PR do?

#18438 broke the (deprecated) API allowing a user to load a tokenizer from the path to a given file when said tokenizer only needs one file. This PR should fix it.

Fixes #19057

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 16, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the test!

@sgugger sgugger merged commit 9017ba4 into main Sep 16, 2022
@sgugger sgugger deleted the fix_load_tok_one_file branch September 16, 2022 20:11
LysandreJik added a commit that referenced this pull request Sep 16, 2022
* Fix tokenizer load from one file

* Add a test

* Style

Co-authored-by: Lysandre <lysandre.debut@reseau.eseo.fr>
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* Fix tokenizer load from one file

* Add a test

* Style

Co-authored-by: Lysandre <lysandre.debut@reseau.eseo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading tokenizer using from_pretrained seems to be broken for v4
3 participants