Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests for regression in cached non existence #19216

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Sep 27, 2022

What does this PR do?

This PR adds more tests as a follow-up to #19206. None of those tests pass without the fixes in #19206

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 27, 2022

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger merged commit 34be08e into main Sep 27, 2022
@sgugger sgugger deleted the more_tests_cached_file branch September 27, 2022 13:36
sgugger added a commit that referenced this pull request Sep 27, 2022
* More tests for regression in cached non existence

* Style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants