Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require_torch to 2 pipeline tests #20585

Merged
merged 1 commit into from Dec 5, 2022
Merged

Add require_torch to 2 pipeline tests #20585

merged 1 commit into from Dec 5, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Dec 5, 2022

What does this PR do?

The 2 tests are for pytorch, but in TF pipeline test CI job (where torch is not available), it runs with TF models.
This is not expected.

Before #20149, these 2 tests are decorated with require_torch_scatter. After that PR, the tests try to run with TF, but failed with TFTapasMainLayer requires the tensorflow_probability library but it was not found in your environment.
(this is another thing to fix in docker file)

@ydshieh ydshieh changed the title Add require_torch to 2 pipeline tests Add require_torch to 2 pipeline tests Dec 5, 2022
@ydshieh ydshieh requested a review from sgugger December 5, 2022 11:18
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 5, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I broke those, thanks for fixing!

@ydshieh ydshieh merged commit cc8aec6 into main Dec 5, 2022
@ydshieh ydshieh deleted the fix_pipe_test branch December 5, 2022 15:06
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Dec 7, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
venkat-natchi pushed a commit to venkat-natchi/transformers that referenced this pull request Jan 22, 2023
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
miyu386 pushed a commit to miyu386/transformers that referenced this pull request Feb 9, 2023
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants