Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused classifier_dropout in configs #20596

Merged
merged 1 commit into from Dec 5, 2022
Merged

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Dec 5, 2022

What does this PR do?

Similar to #20554, but this time for classifier_dropout.
The existing checkpoints with this attribute in their config files could still be loaded via the **kwargs --> so won't fail.

@sgugger If you would prefer me to cleanup multiple different unused config attributes in a single PR, let me know 馃槈

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 5, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ydshieh ydshieh merged commit 4430b91 into main Dec 5, 2022
@ydshieh ydshieh deleted the cleanup_config_attrs_2 branch December 5, 2022 17:04
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Dec 7, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
venkat-natchi pushed a commit to venkat-natchi/transformers that referenced this pull request Jan 22, 2023
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
miyu386 pushed a commit to miyu386/transformers that referenced this pull request Feb 9, 2023
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants