Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model parallelism: Moving labels to the same device as logits for BridgeTower models #22676

Merged

Conversation

shahad-mahmud
Copy link
Contributor

As suggested in the #22561, moving the labels to the same device as the logits are for the BridgeTower models

@sgugger Can you please review?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 9, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sgugger sgugger merged commit 870d91f into huggingface:main Apr 10, 2023
4 checks passed
@shahad-mahmud shahad-mahmud deleted the model_parallelism_logit_device branch April 10, 2023 14:37
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…dgeTower models (huggingface#22676)

BrideTower Model parallelism logits device for loss calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants