Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch.distributed group initialization for torch_neuron disabled when optimum-neuron is installed #22728

Conversation

michaelbenayoun
Copy link
Member

As per title.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 12, 2023

The documentation is not available anymore as the PR was closed or merged.

Comment on lines 95 to 106
TORCH_COMPILE_BACKENDS = [
"eager",
"aot_eager",
"inductor",
"nvfuser",
"aot_nvfuser",
"aot_cudagraphs",
"ofi",
"fx2trt",
"onnxrt",
"ipex",
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related and shouoldn't be re-added.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error when solving conflicts sorry.

"will fail otherwise."
)
else:
import torch_xla.distributed.xla_backend as xbn
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raise the deprecation warning here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelbenayoun michaelbenayoun merged commit 10fab90 into huggingface:main Apr 12, 2023
@michaelbenayoun michaelbenayoun deleted the torch_distributed_neuron_initialization branch April 12, 2023 15:42
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…when `optimum-neuron` is installed (huggingface#22728)

* Make the process group initialization not happen if optimum_neuron is installed

* Add warning

* Remove list and added warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants