Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Translated serialization.mdx to Korean #22806

Merged
merged 1 commit into from
Apr 25, 2023
Merged

🌐 [i18n-KO] Translated serialization.mdx to Korean #22806

merged 1 commit into from
Apr 25, 2023

Conversation

wonhyeongseo
Copy link
Contributor

@wonhyeongseo wonhyeongseo commented Apr 17, 2023 •
edited

What does this PR do?

Translated the serialization.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

@wonhyeongseo wonhyeongseo mentioned this pull request Apr 17, 2023
Open
84 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 17, 2023 •
edited

The documentation is not available anymore as the PR was closed or merged.

@wonhyeongseo
Copy link
Contributor Author

Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

sim-so
sim-so suggested changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@sim-so sim-so left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원형님의 번역 덕분에 많은 내용을 새로 알게 되었어요!
수식어절이 긴 문장을 나누어 옮겨주신 점이 좋아서 저도 다음 번역에 참고하려고 해요 🙌

: 뒤에 예시가 이어지는 문장과 몇 가지 표현에 대해 제안을 드립니다.
다른 의견이 있는 경우 편히 제안해주시면 좋겠습니다!

docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
0525hhgus
0525hhgus suggested changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 감사합니다! 문서 내 코드와 함께 표현을 고려하신 점이 느껴집니다 👍
저는 마지막 문단에 짧은 리뷰 덧붙였습니다 😄

docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
wonhyeongseo
wonhyeongseo commented Apr 25, 2023
View reviewed changes
Copy link
Contributor Author

@wonhyeongseo wonhyeongseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sim-so and @0525hhgus for your wonderful reviews. Good night 🌙

docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
docs/source/ko/serialization.mdx Outdated Show resolved Hide resolved
@wonhyeongseo wonhyeongseo marked this pull request as ready for review April 25, 2023 15:48
@wonhyeongseo
Copy link
Contributor Author

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

@wonhyeongseo @sim-so @0525hhgus
docs: ko: serialization.mdx
ca390bd 
Co-Authored-By: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-Authored-By: Hyeonseo Yun <0525yhs@gmail.com>
sgugger
sgugger approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sgugger sgugger merged commit d950457 into huggingface:main Apr 25, 2023
2 checks passed
@wonhyeongseo wonhyeongseo deleted the ko-onnx branch April 25, 2023 23:34
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
@wonhyeongseo @sim-so
@0525hhgus @gojiteji
🌐 [i18n-KO] Translated serialization.mdx to Korean (huggingface#22806)
b8d299a 
docs: ko: serialization.mdx

Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@wonhyeongseo @sim-so
@0525hhgus @novice03
🌐 [i18n-KO] Translated serialization.mdx to Korean (huggingface#22806)
0f66c99 
docs: ko: serialization.mdx

Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0525hhgus 0525hhgus 0525hhgus requested changes

@sim-so sim-so sim-so requested changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wonhyeongseo @HuggingFaceDocBuilderDev @sgugger @0525hhgus @sim-so