Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin flax & optax version #22895

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Pin flax & optax version #22895

merged 3 commits into from
Apr 20, 2023

Conversation

amyeroberts
Copy link
Collaborator

What does this PR do?

Failing on main because of a new release of optax. Pinning until compatible versions with jax resolved.

Fixes # (issue)

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's also pin Flax to avoid the CI suddenly breaking at their next release, please.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you two spot things so quickly 👀 ?

@amyeroberts amyeroberts changed the title Pin optax version Pin flax & optax version Apr 20, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 20, 2023

The documentation is not available anymore as the PR was closed or merged.

@amyeroberts amyeroberts merged commit e5f3487 into huggingface:main Apr 20, 2023
4 checks passed
@amyeroberts amyeroberts deleted the pin-optax branch April 20, 2023 16:30
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* Pin optax version

* Pin flax too

* Fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants