Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pt/flax equivalence tests in pytorch bigbird test file #23040

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Apr 28, 2023

What does this PR do?

#21023 fixed random attention issue in Flax bigbird model, and skipped the pt/flax equivalence tests in flax bigbird test file with

reason="Current Pytorch implementation has bug with random attention -> it always uses it not matter if we are in eval/train mode"

We need to skip the pt/flax equivalence tests in pytorch bigbird test file too.

Currently on main, the tests fail

https://app.circleci.com/pipelines/github/huggingface/transformers/63217/workflows/5d512271-f535-44be-a2ec-b95024f8f165/jobs/780069

@ydshieh ydshieh changed the title skip Skip pt/flax equivalence tests in pytorch bigbird test file Apr 28, 2023
@ydshieh ydshieh requested a review from sgugger April 28, 2023 07:05
@ydshieh
Copy link
Collaborator Author

ydshieh commented Apr 28, 2023

cc @Bearnardd

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 28, 2023

The documentation is not available anymore as the PR was closed or merged.

@Bearnardd
Copy link
Contributor

Good catch @ydshieh! I will fix pytorch's big bird implementation today/tomorrow.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Apr 28, 2023

@Bearnardd Thank you 🤗 . Luckily, there is no TFBigBirdModel 😆

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ydshieh ydshieh merged commit 0bf34b1 into main Apr 28, 2023
4 checks passed
@ydshieh ydshieh deleted the fix_bigbird_test branch April 28, 2023 15:00
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
…gface#23040)

skip

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…gface#23040)

skip

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants