Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ffmpeg install for doctests #23329

Closed

Conversation

amyeroberts
Copy link
Collaborator

@amyeroberts amyeroberts commented May 12, 2023

What does this PR do?

tests_pr_documentation_tests fails if run on some docs e.g. docs/source/en/task_summary.mdx as ffmpeg is not installed.

Install ffmpeg in pr_documentation_tests CircleCI job.

Despite trying to add changes to the code and docstrings - I was unable to trigger the tests in the CI suite for the doc tests :(

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 12, 2023

The documentation is not available anymore as the PR was closed or merged.

@amyeroberts amyeroberts deleted the add-ffmpeg-doc-tests branch June 14, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants