use _make_causal_mask in clip/vit models #23942
Merged
+96
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashif
changed the title
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Could you also have a second look @amyeroberts please?
Thanks!
amyeroberts
approved these changes
Jun 1, 2023
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
use _make_causal_mask in clip models
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
use _make_causal_mask in clip models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses the
_make_causal_maskhelper to build the causal attention mask which works forbfloat16dtype.the current
_build_causal_attention_maskuses thetorch.triu_which is not supported in pytorch release fixed recently in main: pytorch/pytorch#101414should fix huggingface/diffusers#3453