Add type hints for several pytorch models (batch-2) #25557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nablabits
commented
Aug 17, 2023
Rocketknight1
approved these changes
Aug 17, 2023
src/transformers/models/decision_transformer/modeling_decision_transformer.py
Outdated
Show resolved
Hide resolved
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
This was referenced Aug 25, 2023
nablabits
changed the title
|
This looks good to me now! Ping me whenever you're finished and you want me to merge it. |
Matt, this is fine by me so I'm happy for you to merge it |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* Add missing type hint to cpmant * Add type hints to decision_transformer model * Add type hints to deformable_detr models * Add type hints to detr models * Add type hints to deta models * Add type hints to dpr models * Update attention mask type hint Co-authored-by: Matt <Rocketknight1@users.noreply.github.com> * Update remaining attention masks type hints * Update docstrings' type hints related to attention masks --------- Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* Add missing type hint to cpmant * Add type hints to decision_transformer model * Add type hints to deformable_detr models * Add type hints to detr models * Add type hints to deta models * Add type hints to dpr models * Update attention mask type hint Co-authored-by: Matt <Rocketknight1@users.noreply.github.com> * Update remaining attention masks type hints * Update docstrings' type hints related to attention masks --------- Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
* Add missing type hint to cpmant * Add type hints to decision_transformer model * Add type hints to deformable_detr models * Add type hints to detr models * Add type hints to deta models * Add type hints to dpr models * Update attention mask type hint Co-authored-by: Matt <Rocketknight1@users.noreply.github.com> * Update remaining attention masks type hints * Update docstrings' type hints related to attention masks --------- Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses some of the models in #16059
Who can review?
@Rocketknight1, please