Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add madlad-400 MT models #27471

Merged
merged 6 commits into from Nov 28, 2023
Merged

Add madlad-400 MT models #27471

merged 6 commits into from Nov 28, 2023

Conversation

jbochi
Copy link
Contributor

@jbochi jbochi commented Nov 13, 2023

What does this PR do?

Fixes #26696

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker

@amyeroberts
Copy link
Collaborator

Thanks for adding @jbochi! Let us know when you're ready for a review.

I've set the failed tests to re-run as it seems there was a transient connection error causing them to fail.

@jbochi
Copy link
Contributor Author

jbochi commented Nov 14, 2023

Thanks for re-running the tests, @amyeroberts .

The PR is ready for review. I don't think the previous failure was related to my changes.

@jbochi
Copy link
Contributor Author

jbochi commented Nov 14, 2023

The tests passed this time. 😌

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

Just a few small notes on the doc page structure.

docs/source/en/model_doc/madlad-400.md Outdated Show resolved Hide resolved
docs/source/en/model_doc/madlad-400.md Outdated Show resolved Hide resolved
jbochi and others added 2 commits November 15, 2023 16:28
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jbochi
Copy link
Contributor Author

jbochi commented Nov 16, 2023 via email

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks for iterating!

Just one little nit on the abstract formatting. I can transfer the checkpoints, the checkpoint paths can be updated and then we can merge 🤗

docs/source/en/model_doc/madlad-400.md Outdated Show resolved Hide resolved
@amyeroberts
Copy link
Collaborator

Thank you for filling out the model cards so beautifully 🙏

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jbochi
Copy link
Contributor Author

jbochi commented Nov 17, 2023

Thanks for the review!

@amyeroberts
Copy link
Collaborator

Hi @jbochi. Apologies for the delay in getting back to you - I'm also learning about the intricacies of org weights too! For the model weights, would you prefer that we move the original checkpoint repos directly under google or duplicate, so that yours still exist under your profile?

@jbochi
Copy link
Contributor Author

jbochi commented Nov 23, 2023 via email

@amyeroberts
Copy link
Collaborator

@jbochi If they're moved then they wouldn't exist under your profile any more at all. I believe it would error-out saying that the repo doesn't exist if someone tried: AutoTokenizer.from_pretrained("jbochi/madlad400-3b-mt"). Is this still OK or would you rather we copy?

@jbochi
Copy link
Contributor Author

jbochi commented Nov 24, 2023 via email

@amyeroberts
Copy link
Collaborator

@jbochi Yep! All done. I've set the doc tests to re-run which should pass now the google checkpoints exist 🤞

@jbochi
Copy link
Contributor Author

jbochi commented Nov 27, 2023 via email

@amyeroberts
Copy link
Collaborator

@jbochi One last final update - the doctests are failing with a timeout. Could you add the model doc page madlad-400.md to the not_doctested.txt page?

Tests are timing out.
@jbochi
Copy link
Contributor Author

jbochi commented Nov 28, 2023

@jbochi One last final update - the doctests are failing with a timeout. Could you add the model doc page madlad-400.md to the not_doctested.txt page?

Sure. Done!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@amyeroberts
Copy link
Collaborator

@jbochi Awesome - thanks again for adding!

@amyeroberts amyeroberts merged commit fdd86ee into huggingface:main Nov 28, 2023
22 checks passed
@jbochi
Copy link
Contributor Author

jbochi commented Nov 28, 2023

Thanks for the review and all the help, @amyeroberts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MADLAD-400 MT Models
3 participants