Move tensors to same device to enable IDEFICS naive MP training #27746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
LGTM - thanks for adding this fix!
@ArthurZucker would setting the attentions here to the logits device cause any issues?
ArthurZucker
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Looks alright! Would be good to add a test for this IMO @amyeroberts but otherwise good to go
|
For the test I suggest to do it in a follow-up PR to test that for all architectures, through a test that runs on the daily CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #27736
logits,labels, andattention_maskare expected to be on the same device.This PR moves these tensors to the same device, making IDEFICS training compatible with naive model parallelism.
See also #22561
@amyeroberts @ArthurZucker @younesbelkada