Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses dvclive_test mode in examples/pytorch/test_accelerate_examples.py #27763

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

dberenbaum
Copy link
Contributor

What does this PR do?

Fixes tests in examples/pytorch/test_accelerate_examples.py to use test mode for dvclive tracking, so that it does not try to do git operations in tests/CI.

Fixes comments here and here.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Could you take a look @muellerzr? I didn't find anywhere else that needs a change, but you likely know better whether I missed any tests.

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes this is indeed the right place for it :)

@muellerzr
Copy link
Contributor

cc @ArthurZucker this will fix a ton of pesky test failures in the examples :)

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗

@ArthurZucker ArthurZucker merged commit fe41647 into huggingface:main Nov 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants