Don't set finetuned_from if it is a local path
#28482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
amyeroberts
reviewed
Jan 12, 2024
| @@ -559,7 +559,11 @@ def filter_corrupt_images(examples): | |||
| trainer.save_metrics("eval", metrics) | |||
|
|
|||
| # 11. Write Training Stats and push to hub. | |||
| kwargs = {"finetuned_from": model_args.model_name_or_path, "tasks": "contrastive-image-text-modeling"} | |||
| finetuned_from = model_args.model_name_or_path | |||
| # If from a local directory, don't set `finetuned_from` | |||
There was a problem hiding this comment.
It would be better to describe why here in the comment. It's clear from the code this is what's happening but not the motivation
There was a problem hiding this comment.
Changed it to
# If from a local directory, don't set `finetuned_from` as this is required to be a valid repo. id on the Hub.
amyeroberts
approved these changes
Jan 12, 2024
staghado
pushed a commit
to staghado/transformers
that referenced
this pull request
Jan 15, 2024
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
MadElf1337
pushed a commit
to MadElf1337/transformers
that referenced
this pull request
Jan 15, 2024
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
wgifford
pushed a commit
to wgifford/transformers
that referenced
this pull request
Jan 21, 2024
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
AjayP13
pushed a commit
to AjayP13/transformers
that referenced
this pull request
Jan 22, 2024
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
base_modelissue in #28286