Update legacy Repository usage in various example files #29085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on/run_glue_no_trainer.py` Marked for deprecation here https://huggingface.co/docs/huggingface_hub/guides/upload#legacy-upload-files-with-git-lfs
amyeroberts
reviewed
Feb 19, 2024
@amyeroberts sure! Could you point out if I can find why the CI actions are failing? In the details it just shows as failed without any details. I ran the quality tools / tests locally and all seemed ok. |
|
@Hvanderwilk Great - thanks! For the failing runs on CI there's two things you'll need to do to get things passing:
|
Hvanderwilk
force-pushed
the
sequence_classification_example_upload_hub
branch
from
1d9ae08
to
8366d95
Compare
Hvanderwilk
force-pushed
the
sequence_classification_example_upload_hub
branch
from
8366d95
to
da71021
Compare
Hvanderwilk
changed the title
amyeroberts
reviewed
Mar 11, 2024
examples/research_projects/codeparrot/scripts/codeparrot_training.py
Outdated
Show resolved
Hide resolved
examples/pytorch/image-classification/run_image_classification_no_trainer.py
Outdated
Show resolved
Hide resolved
examples/pytorch/semantic-segmentation/run_semantic_segmentation_no_trainer.py
Outdated
Show resolved
Hide resolved
Comment on lines
317
to
321
| with open(os.path.join(args.output_dir, ".gitignore"), "w+") as gitignore: | ||
| if "step_*" not in gitignore: | ||
| gitignore.write("step_*\n") | ||
| if "epoch_*" not in gitignore: | ||
| gitignore.write("epoch_*\n") |
There was a problem hiding this comment.
Alright, I've added it back and added it in an example which did not have it.
Hvanderwilk
force-pushed
the
sequence_classification_example_upload_hub
branch
from
9a2239f
to
e11fba4
Compare
amyeroberts
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The usage in the example is marked for deprecation here https://huggingface.co/docs/huggingface_hub/guides/upload#legacy-upload-files-with-git-lfs. Use the new recommended methods.
I've further removed the
epoch_/step_gitignores, that seems a bit against the purpose of doing the intermediate push, for which some examples store models at an epoch.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.