Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kwargs handling in generate_with_fallback #29225

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Fix kwargs handling in generate_with_fallback #29225

merged 6 commits into from
Apr 3, 2024

Commits on Feb 22, 2024

  1. Fix generate_with_fallback **kwargs

    @cifkao
    cifkao committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    9a692bc View commit details
    Browse the repository at this point in the history

  2. Change pop to get

    @cifkao
    cifkao committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    6b38f76 View commit details
    Browse the repository at this point in the history

  3. Delete keys from kwargs to prevent overriding generation_config

    @cifkao
    cifkao committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    2671894 View commit details
    Browse the repository at this point in the history

  4. Revert to passing kwargs by reference, but make a (shallow) copy

    @cifkao
    cifkao committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    c74edca View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. dict -> copy.copy

    @cifkao
    cifkao committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    64e3163 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Add test_whisper_longform_multi_batch_beam

    @cifkao
    cifkao committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    39d09a3 View commit details
    Browse the repository at this point in the history