Fix Base Model Name of LlamaForQuestionAnswering #29258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
True, I didn't think about whether renaming the variable would be a breaking change. In this case, setting |
ArthurZucker
approved these changes
Feb 29, 2024
|
@younesbelkada feel free to merge if it is alright with you |
younesbelkada
approved these changes
Mar 1, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
calpt
added a commit
to adapter-hub/adapters
that referenced
this pull request
Apr 6, 2024
Changes: - HF changed parts of the Llama model implementation - HF added a `LlamaForQuestionAnswering`. However, this model has a wrong base model name. I added a workaround that solves this problem until this is fixed in Transformers (huggingface/transformers#29258) --------- Co-authored-by: calpt <calpt@mail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
LlamaForQuestionAnsweringcurrently has theLlamaModelin thetransformervariable. This does not match thebase_model_prefixset inLlamaPreTrainedModel, which is "model".This Pull Request changes the name from
transformertomodelinLlamaForQuestionAnsweringWho can review?