Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaults + correct error in documentation for Mixtral configuration #29436

Closed
wants to merge 1 commit into from

Conversation

kalomaze
Copy link

@kalomaze kalomaze commented Mar 4, 2024

What does this PR do?

  • The default value for the max_position_embeddings was erroneously set to 4096 * 32. This has been corrected to 32768
  • Mixtral does not use Sliding Window Attention, it is set to null in the official config.json. So, the notice about the model using SWA has been removed.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM could you make sur the CI is green! 🤗

Copy link

github-actions bot commented Apr 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants