Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure on DeepSpeed #29444

Merged
merged 2 commits into from Mar 6, 2024
Merged

Fix test failure on DeepSpeed #29444

merged 2 commits into from Mar 6, 2024

Conversation

muellerzr
Copy link
Contributor

@muellerzr muellerzr commented Mar 4, 2024

What does this PR do?

It looks like grad_norm might not always be a torch.Tensor, as that merged PR breaks all of our deepspeed trainer tests. In such cases, we can check for item before calling it. Follow-up to #29212, linked to #27326

Fixes failing DeepSpeed tests

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker @pacman100

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@shubhanjan99
Copy link

Fixes the issue mentioned in #29207 , but I haven't checked whether #29212 fixed it or not for me.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is not a float, what is it that is returned? A list ?

@muellerzr
Copy link
Contributor Author

A tensor, actually

@muellerzr muellerzr merged commit 9322576 into main Mar 6, 2024
21 checks passed
@muellerzr muellerzr deleted the muellerzr-deepspeed-item branch March 6, 2024 12:11
damithsenanayake pushed a commit to damithsenanayake/transformers that referenced this pull request Mar 7, 2024
@lucasjinreal
Copy link

When will update to pypi?

this one break training on deepspeed now.

@ArthurZucker
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants