Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BLIP for auto VQA #29499

Merged
merged 3 commits into from Mar 7, 2024
Merged

Conversation

regisss
Copy link
Contributor

@regisss regisss commented Mar 7, 2024

What does this PR do?

When using a BLIP (not BLIP2) model with a pipeline for VQA, the following warning is displayed:

The model 'BlipForQuestionAnswering' is not supported for visual-question-answering. Supported models are ['Blip2ForConditionalGeneration', 'ViltForQuestionAnswering'].

Since there are some BLIP models for VQA on the hub (e.g. this one), this PR adds BLIP to the VQA auto class.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is already tested in BlipVQAModelTest but can you try adding the class to pipeline_model_mapping :

class BlipModelTest(ModelTesterMixin, PipelineTesterMixin, unittest.TestCase):
    all_model_classes = (BlipModel,) if is_torch_available() else ()
    pipeline_model_mapping = (
        {
            "feature-extraction": BlipModel,
            "image-to-text": BlipForConditionalGeneration,
        }
        if is_torch_available()
        else {}
    )

If it was here we would have probably caught the failure!

@regisss
Copy link
Contributor Author

regisss commented Mar 7, 2024

Done @ArthurZucker! Actually it's just a warning so not sure the test would catch it.

@ArthurZucker ArthurZucker merged commit 979fccc into huggingface:main Mar 7, 2024
21 checks passed
damithsenanayake pushed a commit to damithsenanayake/transformers that referenced this pull request Mar 7, 2024
* Enable BLIP for auto VQA

* Make style

* Add VQA to BLIP pipeline tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants