Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use warning_advice for tensorflow warning #29540

Merged
merged 1 commit into from Mar 8, 2024

Conversation

winstxnhdw
Copy link
Contributor

@winstxnhdw winstxnhdw commented Mar 8, 2024

What does this PR do?

Hey @amyeroberts, as discussed in #27214, we are now using warning_advice instead of warning. This will allow us to disable this warning via TRANSFORMERS_NO_ADVISORY_WARNINGS=1.

Ref #27214

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@winstxnhdw winstxnhdw changed the title feat: use warning_advice instead of tensorflow warning feat: use warning_advice for tensorflow warning Mar 8, 2024
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks for adding!

@amyeroberts amyeroberts merged commit 0290ec1 into huggingface:main Mar 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants