Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MaskFormer, Mask2Former] Use einsum where possible #29544

Merged
merged 2 commits into from Mar 13, 2024

Conversation

amyeroberts
Copy link
Collaborator

What does this PR do?

einsum operations were removed from mask2former, oneformer and maskformer in #25297 to enable tracing on the models. This was with pytorch 2.0.1

This however, causes a large memory footprint, partially addressed in #25741. However, the models remain very slow.

Testing on recent versions of python >= 2.1 tracing now works for einsum operations.

This PR adds back the previous einsum operations, falling back to the slow but compatible versions when pytorch < 2.1 and the model is being traced.

Fixes #27650

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amyeroberts amyeroberts requested a review from ydshieh March 8, 2024 20:27
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice it works now for torch >= 2.1. Thank you for the update.

@amyeroberts amyeroberts merged commit 88a4f68 into huggingface:main Mar 13, 2024
18 checks passed
@amyeroberts amyeroberts deleted the mask2former-speed-up branch March 13, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mask2Former slowdown starting from version 4.32.0
3 participants