Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error: TypeError: Object of type Tensor is not JSON serializable … #29568

Merged
merged 2 commits into from Mar 11, 2024

Conversation

yuanzhoulvpi2017
Copy link
Contributor

@yuanzhoulvpi2017 yuanzhoulvpi2017 commented Mar 10, 2024

…trainer

What does this PR do?

Fixes issue list:

  1. https://huggingface.co/google/gemma-7b/discussions/54
  2. [https://github.com/[BUG] 训练完模型保存报错 QwenLM/Qwen#1115)(https://github.com/[BUG] 训练完模型保存报错 QwenLM/Qwen#1115)
  3. trainer bug leads into log failure #29207

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerzr and @pacman100

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detach is a bit safer, nice!

@muellerzr
Copy link
Contributor

cc @amyeroberts

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@amyeroberts amyeroberts merged commit 47c9570 into huggingface:main Mar 11, 2024
21 checks passed
@yuanzhoulvpi2017 yuanzhoulvpi2017 deleted the fix_grad_norm_2_log branch March 11, 2024 23:32
@echo-valor
Copy link

佬,很强

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants