Stop passing None to compile() in TF examples #29597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion for run_text_classification.py
Rocketknight1
changed the title
4 tasks
amyeroberts
approved these changes
Mar 11, 2024
| @@ -706,7 +706,7 @@ def compute_metrics(p: EvalPrediction): | |||
| model.compile(optimizer=optimizer, jit_compile=training_args.xla, metrics=["accuracy"]) | |||
|
|
|||
| else: | |||
| model.compile(optimizer=None, jit_compile=training_args.xla, metrics=["accuracy"]) | |||
| model.compile(optimizer="sgd", jit_compile=training_args.xla, metrics=["accuracy"]) | |||
There was a problem hiding this comment.
Can you add a comment here saying optimizer value doesn't mattr as it won't be used?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TensorFlow used to accept a value of
Nonefor the optimizer argument incompile(), as long as you didn't actually try tofit()the resulting model, but now it doesn't. This PR passes a dummysgdoptimizer instead to avoid that issue.It also reworks the sample invocation given for
run_text_classification.pyto avoid confusion.Fixes #29584