Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AutoformerForPrediction example code #29639

Merged

Conversation

m-torhan
Copy link
Contributor

@m-torhan m-torhan commented Mar 13, 2024

What does this PR do?

The pretrained Autoformer config config.json suggests that this model was trained without using static real features. However, in the sample code the model is called with it which causes exception to be raised as mentioned in #29565. This PR removes that parameter from model call and fixes the issue.

Fixes #29565

Who can review?

@kashif

@kashif
Copy link
Contributor

kashif commented Mar 13, 2024

wonder if it makes sense to just put a comment on those? I still wanted folks to know how to call this with these features if they exist?

@m-torhan m-torhan force-pushed the fix-autoformer-for-prediction-example branch 3 times, most recently from 3842db3 to c85b246 Compare March 14, 2024 09:04
@m-torhan
Copy link
Contributor Author

Added a tip about static real features usage

@kashif kashif self-requested a review March 14, 2024 09:11
@m-torhan m-torhan force-pushed the fix-autoformer-for-prediction-example branch from c85b246 to 7739462 Compare March 14, 2024 23:03
Signed-off-by: Maciej Torhan <maciek97x@gmail.com>
@m-torhan m-torhan force-pushed the fix-autoformer-for-prediction-example branch from 7739462 to 864eff1 Compare March 14, 2024 23:07
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for iterating!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@amyeroberts amyeroberts merged commit 8a3cfaa into huggingface:main Mar 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoformerForPrediction example not working
4 participants