Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove broken ChatML format link from chat_templating.md #29643

Merged
merged 4 commits into from Mar 13, 2024

Conversation

aaronjimv
Copy link
Contributor

What does this PR do?

The link to ChatML format in chat_templating.md is generated a 404 error since it's been removed from the openai-python repo and hasn't been updated.

This was talked in #29559 and this PR remove that link from other documentations sources.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@stevhliu

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@stevhliu stevhliu merged commit f738ab3 into huggingface:main Mar 13, 2024
8 checks passed
@aaronjimv aaronjimv deleted the remove_chat_link branch March 13, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants