New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typos #29653
fix: typos #29653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@testwill There's a failing CI test which will need to pas before merging in. Running |
python utils/check_copies.py --fix_and_overwrite |
hmmm, that's odd. I'm able to run |
Python 2.7.18 |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
OK, that's the issue, the library only supports python3. The recommended way to develop is to work from a python3 virtual environment, in which |
Python 3.8.10 ,Also installed in the local environment |
@testwill I'm assuming that you run python 3.8 through the |
run cmd same error |
@testwill I don't suggest setting an alias like this, as it can lead to all sorts of weird behaviour. As per the contribution guidelines, I suggest making a virtual env and running from there. |
Do all these documents need to be committed? |
@testwill No, you shouldn't need to add these. Can you rebase on main to include any recent upstream changes? This should fix this |
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
ok |
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.