Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MLFlow version detection more robust and handles mlflow-skinny #29957

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Make MLFlow version detection more robust and handles mlflow-skinny #29957

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
def9a97
Make MLFlow version detection more robust and handles mlflow-skinny
helloworld1 Mar 29, 2024
a616ce9
Make function name more clear and refactor the logic
helloworld1 Apr 1, 2024
1fb2ed2
Further refactor
helloworld1 Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 3 additions & 10 deletions src/transformers/integrations/integration_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,6 @@ def is_mlflow_available():
return importlib.util.find_spec("mlflow") is not None


def get_mlflow_version():
try:
return importlib.metadata.version("mlflow")
except importlib.metadata.PackageNotFoundError:
return importlib.metadata.version("mlflow-skinny")


def is_dagshub_available():
return None not in [importlib.util.find_spec("dagshub"), importlib.util.find_spec("mlflow")]

Expand Down Expand Up @@ -1005,12 +998,12 @@ def setup(self, args, state, model):
self._experiment_name = os.getenv("MLFLOW_EXPERIMENT_NAME", None)
self._flatten_params = os.getenv("MLFLOW_FLATTEN_PARAMS", "FALSE").upper() in ENV_VARS_TRUE_VALUES
self._run_id = os.getenv("MLFLOW_RUN_ID", None)
self._async_log = False

# "synchronous" flag is only available with mlflow version >= 2.8.0
# https://github.com/mlflow/mlflow/pull/9705
# https://github.com/mlflow/mlflow/releases/tag/v2.8.0
if packaging.version.parse(get_mlflow_version()) >= packaging.version.parse("2.8.0"):
self._async_log = True
self._async_log = packaging.version.parse(self._ml_flow.__version__) >= packaging.version.parse("2.8.0")

logger.debug(
f"MLflow experiment_name={self._experiment_name}, run_name={args.run_name}, nested={self._nested_run},"
f" tags={self._nested_run}, tracking_uri={self._tracking_uri}"
Expand Down