Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto tests #30067

Merged
merged 2 commits into from Apr 5, 2024
Merged

Fix auto tests #30067

merged 2 commits into from Apr 5, 2024

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Apr 5, 2024

What does this PR do?

Some failures after #29112 due to the wrong Hub repo. being used

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure I understand what difference this makes as google-bert/bert-base-uncased exist?

@ydshieh
Copy link
Collaborator Author

ydshieh commented Apr 5, 2024

@ArthurZucker

it exists, it's not the problem of the existing or not. It's we use

   model_name = "google-bert/bert-base-uncased"

but the check after it

   self.assertIsInstance(config, GPT2Config)

claim it is GPT2Config. And it fails as the claim is false obviously

It's just #29112 updated model_name while not update GPT2Config etc (or use the repo. corresponding to the original previous repo)

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good thanks for the explanation!

@ydshieh ydshieh merged commit 9b5a645 into main Apr 5, 2024
18 checks passed
@ydshieh ydshieh deleted the fix_auto_test branch April 5, 2024 15:49
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
itazap pushed a commit that referenced this pull request May 14, 2024
* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants